Add Time duration support #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathantneal
approved these changes
Jun 24, 2019
| @@ -14,7 +14,7 @@ const { registerWalker } = require('../walker'); | |||
|
|
|||
| const Node = require('./Node'); | |||
|
|
|||
| const unitRegex = /%|ch|cm|em|ex|in|mm|pc|pt|px|q|rem|vh|vmax|vmin|vw$/i; | |||
| const unitRegex = /%|ch|cm|em|ex|in|mm|ms|pc|pt|px|s|q|rem|vh|vmax|vmin|vw$/i; | |||
There was a problem hiding this comment.
As defined in:
CSS Level 2: https://www.w3.org/TR/CSS2/aural.html#times
CSS Values Level 3: https://drafts.csswg.org/css-values-3/#time
CSS Values Level 4: https://drafts.csswg.org/css-values-4/#time
|
@shellscape, this seems pretty clean. I‘m not sure why the |
|
I tried to add also angle units. But it doesn't take |
|
Thanks for putting this together 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Please Describe Your Changes
This PR adds support for time duration values. Nothing more.